Construct dependency fingerprint from canonicalized hash tree #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some debugging, I found that the current dependency fingerprinting code is hashing the dependency structure basically as-is, leaving it brittle against changes in things like dependency ordering and map iteration order. Instead, we should canonicalize each dependency coordinate and roll things up into a tree of hashes.
A little debug printing shows that a dependency calculation for the current code is hashing lots of raw data structures:
After this change, the same debugging shows the tree rollup:
I tested and reordering dependencies within a project no longer changes the dependency fingerprint for that project.