Update merged profile paths #83
Conversation
* Don't include monolith project paths * Ensure active profiles are activated in subprojects before reading and absolutizing paths
ff745ab to
92679f5
Compare
|
This is failing on CI because it relies on a change to EDIT: I modified this to be less efficient, but it's now functional down to the version on CI. |
…more recent Leiningen version
| absolutizes any paths in the subproject that may be relative." | ||
| [monolith [_project-name subproject]] | ||
| (-> subproject | ||
| (project/project-with-profiles) |
There was a problem hiding this comment.
This step unfortunately does a lot of file system access on Leiningen < 2.9.2: https://github.com/technomancy/leiningen/blob/f3864bc35d8280a8461b7f6c593b1919a75bef7f/leiningen-core/src/leiningen/core/project.clj#L871
On >= 2.9.2, the function has a second arity that allows for profiles to be passed in:
https://github.com/technomancy/leiningen/blob/df32368a84c3441b59d0310a991a3e10c91b28b8/leiningen-core/src/leiningen/core/project.clj#L878
|
Hmm, 2.9.2 has been out for a while, but I'm not keen on adding a version requirement just for this specific edge case. I think this can be closed for now and maybe revisited if/when leiningen 3.0.0 becomes a thing. |
|
Sounds good. I'm sure that when/if it becomes a thing, everything is going to break anyway 🤷♀️ |
|
To be clear, this does work on lein 2.9, but with that extensive profile reading, it might degrade the performance of with-all. |
Removes monolith project paths and dependencies from the output, and ensures that profiles active in the monolith are activated in subprojects before reading and absolutizing paths.
As discussed in #75.