Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only unlink internal checkouts by default #80

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Conversation

greglook
Copy link
Collaborator

Running lein monolith unlink in a subproject will blindly delete the checkouts/ directory and everything in it. This violates expectations users have about lein-monolith only operating on internal projects by default. To fix this, change the unlink task to default to only removing links that resolve to an internal subproject, unless the :all option is given. I also added arguments so you can choose to unlink specific projects.

Fixes #66

@greglook greglook requested a review from a team September 29, 2020 18:16
Copy link
Member

@jstokes jstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@greglook greglook merged commit b4de04f into master Sep 29, 2020
@greglook greglook deleted the unlink-internal-only branch September 29, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlink task wipes out external checkouts
2 participants