Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure resume suggestions are shell-escaped #72

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Ensure resume suggestions are shell-escaped #72

merged 1 commit into from
Sep 24, 2020

Conversation

greglook
Copy link
Collaborator

Fixes #27

Testing

I induced a failure in the example projects and ran an iteration over them:

% lein monolith each do test, shell echo 'foo bar baz'
Applying do test, shell echo foo bar baz to 3 subprojects...

...

Resume with: lein monolith each :start example/lib-b do test, shell echo 'foo bar baz'

Completed example/lib-b (2/3) in 0:01.113
Tests failed.

jstokes
jstokes approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@jstokes jstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐚

@greglook greglook merged commit 27d0ae3 into master Sep 24, 2020
@greglook greglook deleted the resume-escaping branch September 24, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstokes jstokes jstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resume suggestions should be shell escaped
2 participants
@greglook @jstokes