Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions thrown in each :output runs #56

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

drewinglis
Copy link
Contributor

Currently, if a lein monolith each :output ,,, task throws an exception, the exception is not recorded in the task's output file (it is only recorded in the overall output). This starts recording the exception to the task's output file as well.

@drewinglis drewinglis requested a review from greglook October 29, 2019 21:31
Copy link
Collaborator

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@drewinglis drewinglis merged commit 1eed7e4 into master Oct 30, 2019
@drewinglis drewinglis deleted the drew/catch-each-error branch October 30, 2019 17:33
@greglook
Copy link
Collaborator

Forgot to mention, please add this fix to the CHANGELOG.

drewinglis added a commit that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants