Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-puget #49

Merged
merged 11 commits into from
Oct 7, 2019
Merged

Un-puget #49

merged 11 commits into from
Oct 7, 2019

Conversation

greglook
Copy link
Collaborator

@greglook greglook commented Oct 6, 2019

Description

I recently ran into brandonbloom/fipp#60 when CircleCI updated their implicit Java version to 11 on their Clojure container images. Currently lein-monolith pulls in puget to do its ANSI coloring as well as some canonical printing for project fingerprints. There's not a huge dependency on the actual pretty-printing functionality, so we can simplify some headaches by dropping puget.

Changes

  • Pull in basic ANSI color coding functionality in lein-monolith.color.
  • Replace all references to puget.color.ansi with the new color codes.
  • Replace puget pretty printing with either a simpler colored output or a more basic pprint or pr-str call.
  • Rewrite fingerprint canonicalization functions to operate at a more basic key/value level instead of leveraging puget for rendering.

Testing

Local tests, example test project.

@greglook greglook requested a review from a team October 6, 2019 02:33
Copy link
Contributor

@drewinglis drewinglis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough. 👍

@greglook greglook merged commit 3a28f65 into master Oct 7, 2019
@greglook greglook deleted the un-puget branch October 7, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants