Don't exit each in the no-op case to allow composition
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglook
reviewed
Mar 11, 2019
| (ansi/sgr (str/join " " task) :bold :cyan) | ||
| (ansi/sgr (count targets) :cyan) | ||
| (u/human-duration elapsed))))))) | ||
| (do |
There was a problem hiding this comment.
Might be cleaner to pull this whole block out as a separate function, now. Looks like the majority of the inputs already get collected as ctx below.
greglook
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lein monolith eachcurrently exits with 0 if the selectors match zero projects. This terminates the leiningen process even if you try to composeeachin a high-level task:Instead it now "soft-exits" to allow subsequent tasks.