Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow graph subtask to take targeting options #43

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Allow graph subtask to take targeting options #43

merged 2 commits into from
Jan 17, 2019

Conversation

greglook
Copy link
Collaborator

This is useful for scoping the resulting graph down to a smaller set of projects.

@greglook greglook requested a review from aengelberg January 17, 2019 05:20
aengelberg
aengelberg reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@aengelberg aengelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about the zero case, but otherwise looks good.

src/lein_monolith/task/graph.clj Outdated Show resolved Hide resolved
aengelberg
aengelberg approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@aengelberg aengelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@greglook greglook merged commit 23d1834 into develop Jan 17, 2019
@greglook greglook deleted the graph-target-opts branch January 17, 2019 20:35
aengelberg added a commit that referenced this pull request Apr 25, 2019
@aengelberg
Add #43 to changelog
6f2e2f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aengelberg aengelberg aengelberg approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greglook @aengelberg