Fix crash in lein-monolith graph when root and cluster name are equal #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglook
requested changes
Aug 17, 2017
src/lein_monolith/task/graph.clj
Outdated
| @@ -9,6 +9,11 @@ | |||
|
|
|||
| (def image-name "project-hierarchy.png") | |||
|
|
|||
| (defn cluster->descriptor | |||
| [monolith-root subdirectory] | |||
| (when-not (= monolith-root subdirectory) | |||
There was a problem hiding this comment.
Style: I have a minor preference for (when (not= ... here. Please preserve the two-line spacing between top-level vars as well.
There was a problem hiding this comment.
While I was writing it, I debated whether to use not= - seems I picked wrong, haha.
I've corrected the spacing, as well.
greglook
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
lein monolith graphon our project currently producesjava.lang.StringIndexOutOfBoundsException: String index out of range: -1. This only happens when the name of a cluster (the%in the anonymous function) is equal to the root of the project.The end result after this PR is that clusters at the root of the project have no label, while those that aren't get a label.