Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/deploy documentation #234

Merged

Conversation

brianneoberson
Copy link
Contributor

@brianneoberson brianneoberson commented Feb 5, 2024

Build/Deploy documentation was updated in the wiki: https://github.com/amosproj/amos2023ws02-pitest-ide-plugin/wiki/Build--deploy-documentation and converted to pdf for the deliverables.

Signed-off-by: brianneoberson <brianne.oberson@epfl.ch>
@timherzig
Copy link
Contributor

Looks good to me. One small thing, in 4.2 Publishing the companion Gradle plugin maybe both companion plugins should be mentioned. :)

@lheimbs
Copy link
Contributor

lheimbs commented Feb 5, 2024

Please get the terminology straight in regards to the companion gradle plugin and the coverage-reporter pitest dependency. Calling the coverage-reporter a gradle plugin can be misleading and may lead to users trying to include it in the plugins section...

If have edited the wiki page

Signed-off-by: Tim Herzig <tim.herzig@hotmail.com>
…thub.com:amosproj/amos2023ws02-pitest-ide-plugin into Homework/196-Finalize-Build/Deploy-Documentation
Copy link
Contributor

@QW3RAT QW3RAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brianneoberson brianneoberson merged commit a54bd6f into main Feb 6, 2024
13 checks passed
@emuguy1 emuguy1 deleted the Homework/196-Finalize-Build/Deploy-Documentation branch February 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants