Bugfix/224 all kinds of fixes #233

lheimbs · 2024-02-03T15:52:10Z

Soooooooo...

this is a lot.
I'm sorry.

We'll have to see if we really want to accept this right before the final release.
Might also have to merge this afterwards.

Changes

Companion plugin

add task to check for the other plugins

Intellij plugin

PluginCheck: Check first if new task is available and then the task is executed before running a pitest task and the tasks output tells us if the pitest plugin is loaded.
PluginCheck: Checks are only ever run when executing pitest. No other times.
PluginCheck: Also error info is show in the tool window but other than that there is only a small tooltip when an error is detected. No disabling anything anymore.
Removed all file listener and file parsing shenanigans
Gradle can give us test folders when an intellij idea is used so added that to the testenv checker
Fixed a bug where right click on the gutter icon caused an exception
Slightly adjusted the annotations (IP wanted less intrusive killed display)
Cleaned up the tool window factory.
Allow users to add gradle cli options in settings. Also shows what is selected in settings better.

This fixes #213 #224 #228 and also most of the issues found by the IP.

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

also uses variables for versions as suggested by sonarlint Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

IPs didn't care about getting a warning on project boot. So to simplify things we'll drop the listener and only analyze the plugins when the user runs an action. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

This lets us use this also in dynamically created actions which can't inherit from this. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

To enable right clicking, the Gutter action will be created dynamically. The hover action was not used for a long time. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

This completely dumps any parsing of files in favor of a gradle task registered by the compagnion plugin which existence signals the presence of the compagnion. In turn the compagnion task check for the solidsoft and driodsondriods plugins and prints then in json form in the gradle task. If we then parse the output of that task we get the presence of the pitest plugins. The gradle task is also able to get the available android build types. Sadly i still haven't found a way to get the currently set build type. I think that information mainly lives in the intellij android plugin... Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Needed to dynamically create the action for that for some reason. Has something to do with the ExecutorAction stuff from the docs but honestly I didn't quite get it. Anyways this was the reason for putting the action exection method in a non-action class Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

IP what they are doing and outright disabling them to do things is not nice. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Killed/No Coverage wont result in a code annotation anymore. Might still need adjusting based on users needs... Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Also changing of contents has been moved into tab specific utility funcitons Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Now applies then correctly to the command Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

As stated before, we are only checking for missing plugins here. This simplifies things and gives users more freedom. Also no more hard error message, only a nudge from the tool window tooltip that something is amiss. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

This only queries gradle for build infos and updates the last found result. All other file watching etc was dropped. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Shoud be more robust with gradle projects. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

happens when gradle is misconfigured and cannot build Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

nikomall34

Two things that I noticed are that the HistoryTab is not getting updated and the when we run pitest for many classes. So the text in the targetClasses JBTextField is very large you cannot resize the window anymore. This is because of the Layout that the FormBuilder uses I guess. I am currently working on these issues and I think we shouldn't put them in this PR so you can merge it.

nikomall34 · 2024-02-05T11:23:09Z

...ate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/configuration/SettingsEditor.kt

@@ -21,19 +23,17 @@ class SettingsEditor : SettingsEditor<RunConfiguration>() {
    private val gradleTaskField: TextFieldWithHistory = TextFieldWithHistory()
    private val gradleExecutableField: TextFieldWithBrowseButton = TextFieldWithBrowseButton()
    private val targetClasses: JBTextField = JBTextField()
-    private val buildTypesField: JBTextField = JBTextField()
+    private val buildTypesField: TextFieldWithHistory = TextFieldWithHistory()
    private val verboseCheckbox = JCheckBox("Enable Pitest verbose mode")


Suggested change

private val verboseCheckbox = JCheckBox("Enable Pitest verbose mode")

private val verboseCheckbox = JBCheckBox("Enable Pitest verbose mode")

nikomall34 · 2024-02-05T11:24:20Z

...ate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/configuration/SettingsEditor.kt

        buildTypesField.text = runConfiguration.buildType
        verboseCheckbox.isSelected = runConfiguration.verbose
+
+        runConfiguration.project.service<PluginCheckerService>().getBuildTypes().forEach { buildType ->
+            buildTypesField.history.add(buildType)


Did you test this here with the history. Because for me it didn't work. Btw how did you trigger a reset?

nikomall34 · 2024-02-05T11:27:34Z

...te/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/services/PluginCheckerService.kt

-        var pitestPluginAvailable: Boolean = false
-        var companionPluginAvailable: Boolean = false
+    private fun getPitestPluginName(): List<String> {
+        val isAndroid = pluginCheckData?.androidPitestPluginApplied ?: false


Suggested change

val isAndroid = pluginCheckData?.androidPitestPluginApplied ?: false

val isAndroid = pluginCheckData?.androidPluginApplied ?: false

I have applied that in 6a6e788
I also added some more doc string in the pluginchecker in an effort to make things clearer

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

lheimbs added 24 commits February 3, 2024 16:40

add task to allow checking for plugins more robust

dc0fbd9

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

add dependencies for gradle tooling api and kotlin json serialisers

53b1b0a

also uses variables for versions as suggested by sonarlint Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

remove file listener

af07b5b

IPs didn't care about getting a warning on project boot. So to simplify things we'll drop the listener and only analyze the plugins when the user runs an action. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

extract action running part to object class

bfbd82a

This lets us use this also in dynamically created actions which can't inherit from this. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

remove unneeded actions.

284ead6

To enable right clicking, the Gutter action will be created dynamically. The hover action was not used for a long time. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

add data class to take the data generated by the new compagnion task

87e4993

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

simplify action by moving some branching into its own method

2223a50

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

use revamped action executor class

d532a28

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

remove disabling on plugin config error

9038196

IP what they are doing and outright disabling them to do things is not nice. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

give error panel more to do by allowing it to change messages

dfd315f

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

adjust annotations style

0658020

Killed/No Coverage wont result in a code annotation anymore. Might still need adjusting based on users needs... Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

revamp tool window factory to always show all tabs

c5e1dac

Also changing of contents has been moved into tab specific utility funcitons Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

improve formatting

be6c2da

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

allow users to specify gradle cli options in settings

af3e712

Now applies then correctly to the command Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

set gradle task and script as default

8630cdf

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

apply changed signature of tool window factory utility class

e87a11c

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

set all thresholds to 0 for them not to bother our executions

ba48cd4

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

simplify launch activity

b24300f

This only queries gradle for build infos and updates the last found result. All other file watching etc was dropped. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

use gradle provided test paths to check for test files

e1f4cd1

Shoud be more robust with gradle projects. Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

add tests for the test file detection

5e16817

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

remove all plugin check file parsing classes

89ff213

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

lheimbs requested review from QW3RAT, timherzig, brianneoberson, lfogarty98 and nikomall34 February 3, 2024 15:52

remove all plugin check file parsing classes

d4b16b3

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

lheimbs added 5 commits February 4, 2024 13:45

add error handling

ffd553b

happens when gradle is misconfigured and cannot build Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

fix bug where empty buildType caused us not to find any reports

8e9dd67

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

catch error and log when pitest reports invalid line numbers

2f6536a

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

increase companion version

ff8394f

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

log and return instead of throw exception

8a273a1

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

lheimbs force-pushed the Bugfix/224-all-kinds-of-fixes branch from be8bfed to 8a273a1 Compare February 4, 2024 13:05

nikomall34 approved these changes Feb 5, 2024

View reviewed changes

use android plugin for android determination and add more doc

6a6e788

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>

lheimbs merged commit 8a28224 into main Feb 5, 2024
17 checks passed

lheimbs deleted the Bugfix/224-all-kinds-of-fixes branch February 5, 2024 12:36

nikomall34 mentioned this pull request Feb 6, 2024

Bugfix/221 file has multiple classes #237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/224 all kinds of fixes #233

Bugfix/224 all kinds of fixes #233

lheimbs commented Feb 3, 2024 •

edited

Loading

nikomall34 left a comment •

edited

Loading

nikomall34 Feb 5, 2024

nikomall34 Feb 5, 2024

nikomall34 Feb 5, 2024

lheimbs Feb 5, 2024

	private val verboseCheckbox = JCheckBox("Enable Pitest verbose mode")
	private val verboseCheckbox = JBCheckBox("Enable Pitest verbose mode")

	val isAndroid = pluginCheckData?.androidPitestPluginApplied ?: false
	val isAndroid = pluginCheckData?.androidPluginApplied ?: false

Bugfix/224 all kinds of fixes #233

Bugfix/224 all kinds of fixes #233

Conversation

lheimbs commented Feb 3, 2024 • edited Loading

Changes

Companion plugin

Intellij plugin

nikomall34 left a comment • edited Loading

Choose a reason for hiding this comment

nikomall34 Feb 5, 2024

Choose a reason for hiding this comment

nikomall34 Feb 5, 2024

Choose a reason for hiding this comment

nikomall34 Feb 5, 2024

Choose a reason for hiding this comment

lheimbs Feb 5, 2024

Choose a reason for hiding this comment

lheimbs commented Feb 3, 2024 •

edited

Loading

nikomall34 left a comment •

edited

Loading