Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/override plugin java 11 #232

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

lheimbs
Copy link
Contributor

@lheimbs lheimbs commented Jan 31, 2024

Removes functional test things that were added from the gradle template but were never actually used.
Also coverage-reporter needed the jvm version set to 11 for it to work work with java 11

Allows for Java 11 usage

Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
Signed-off-by: Lennart Heimbs <lennart@heimbs.me>
@lheimbs lheimbs force-pushed the Bugfix/override-plugin-java-11 branch from 8531048 to 3033d69 Compare January 31, 2024 13:56
Copy link
Contributor

@nikomall34 nikomall34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Since we need some further changes to the coverage-reporter to aggregate the results for each class in a file. I will publish the new coverage-reporter version after these changes.

@lheimbs lheimbs merged commit 9b00502 into main Jan 31, 2024
15 checks passed
@lheimbs lheimbs deleted the Bugfix/override-plugin-java-11 branch January 31, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants