use threading.Lock.acquire's timeout for backpressure rather than sleep #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoffat
reviewed
Feb 11, 2023
amoffat
approved these changes
Feb 11, 2023
JacobHayes
suggested changes
Feb 11, 2023
| # Using a small timeout provides backpressure against code that spams | ||
| # calls to .is_alive() which may block the main thread from acquiring | ||
| # the lock otherwise. | ||
| acquired = self._wait_lock.acquire(timeout=0.1) |
There was a problem hiding this comment.
I still had to set this back down to:
Suggested change
| acquired = self._wait_lock.acquire(timeout=0.1) | |
| acquired = self._wait_lock.acquire(timeout= 0.00001) |
as it was before e9511de.
Given we're using the acquire provided timeout, is that fine now?
|
Ah, a minute too late 😁 |
|
There's still time @JacobHayes, it's only merged into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #649