Properly raise ErrorReturnCode_0 on exit code 0 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where exit code 0 is disallowed via '_ok_code' but the process does exit with this code. get_exc_from_name() negates signal numbers and calls get_rc_exc() with either the exit code or the signal number. Exit codes are unsigned ints and thus >=0. Signal numbers a always >= 1 (see 'kill -l'). get_rc_exc() erroneously handled '0' as a signal when it should be seen as an exit code.
amoffat
approved these changes
Oct 24, 2020
|
Good work Erik 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where exit code 0 is disallowed via '_ok_code' and the process exits with this code.
get_exc_from_name() negates signal numbers and calls get_rc_exc() with either the exit code or the negated signal number. Exit codes are unsigned ints and thus >=0. Signal numbers are always >= 1 (see 'kill -l').
get_rc_exc() erroneously handled '0' as a signal when it should be seen as an exit code.
Fixes #544