Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw string to avoid invalid escape deprecation warning. #482

Closed
wants to merge 1 commit into from
Closed

Use raw string to avoid invalid escape deprecation warning. #482

wants to merge 1 commit into from

Conversation

thatch
Copy link
Contributor

@thatch thatch commented Jul 3, 2019

See https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior for this newly added warning as of 3.6. This change should be fully backwards compatible.

@thatch
Copy link
Contributor Author

thatch commented Jul 5, 2019

Failing tests are because of travis problems, not my change.

@thatch
Copy link
Contributor Author

thatch commented Aug 6, 2019

Ping @amoffat ?

@amoffat amoffat changed the base branch from master to 1.12.6 August 6, 2019 16:02
@amoffat amoffat changed the base branch from 1.12.6 to master August 6, 2019 16:03
@amoffat
Copy link
Owner

amoffat commented Aug 6, 2019

Looks correct @thatch, thank you for the contribution. There's a lot of work involved in shipping the next release, and I'm very busy these days, so it may be awhile before it lands into master.

@amoffat amoffat added this to the release 1.14.15 milestone Nov 25, 2019
@amoffat
Copy link
Owner

amoffat commented Nov 25, 2019

On develop, will go out soon. Thanks again

@amoffat amoffat closed this Nov 25, 2019
bmwiedemann added a commit to bmwiedemann/openSUSE that referenced this pull request Jun 17, 2020
https://build.opensuse.org/request/show/815418
by user StevenK + dimstar_suse
- Update to 1.13.1:
  * regression fix if `_fg=False` [#520](amoffat/sh#520)
  * minor Travis CI fixes [#492](amoffat/sh#492)
  * bugfix for boolean long options not respecting `_long_prefix` [#488](amoffat/sh#488)
  * fix deprecation warning on Python 3.6 regexes [#482](amoffat/sh#482)
  * `_pass_fds` and `_close_fds` special kwargs for controlling file descriptor inheritance in child.
  * more efficiently closing inherited fds [#406](amoffat/sh#406)
  * bugfix where passing invalid dictionary to `_env` will cause a mysterious child 255 exit code. [#497](amoffat/sh#497)
  * bugfix where `_in` using 0 or `sys.stdin` wasn't behaving like a TTY, i
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants