Support finding visit_struct in the system also if it is installed without any CMake config file #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR permits to build matio-cpp when visit_struct is installed, but no CMake config for it is installed (for example as it happens when visit_struct is installed via vcpkg or by manually copying the headers).
Furthermore, I also fixed the logic of
USE_SYSTEM_visit_struct, as as it was before this PR, even if the user explicitly setUSE_SYSTEM_visit_struct, the build silently went back to theUSE_SYSTEM_visit_structset toOFFcase, instead of giving an error.