Switch to use the upstream source code of visit_struct #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to use a commit on the
upstream
branch ofami-iit
's fork ofvisit_struct
. That branch is created by cherry-picking the CMake structured added in ami-iit/visit_struct#1 on the top of the latest commit of the master branch of https://github.com/garbageslam/visit_struct, that gotVISITABLE_INIT
in https://github.com/garbageslam/visit_struct/pull/24/files .Using the upstream source code of
visit_struct
would simplify packaging the library in conda-forge . However, as far as I understood the code is different between https://github.com/garbageslam/visit_struct/pull/24/files and cbeck88/visit_struct#14, so we may want to merge with care. The tests ofmatio-cpp
are passing fine, but I do not know if there is something else we want to check before merging.