-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the drakeSimulator
class and a working example of drake_walking.ipynb
#4
Conversation
As |
drakeSimulator
class and a working example of drake_walking.ipynb
drakeSimulator
class and a working example of drake_walking.ipynb
added drakeSimulator class + drake_walking example
@traversaro, please let me know what to do about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested also on my machine and everything works fine ! Thank you really much @akhilsathuluri for the PR !
Few comments needs to be addressed before merging, I would also ask you if you can generally clean up the code from comments that do not document the code, and open issues if there is anything you would like to implement in the future or features you would like to have in comodo ! Thanks
Ok, in the end we did this, currently private repo available at https://github.com/ami-iit/amo-urdf . |
Pr/akhilsathuluri/4
@CarlottaSartore : I modified some of the methods based on the comments. Do have a look and let me know. |
Ciao @akhilsathuluri , Thank you, and sorry for the delay. Most of the comments have been implemented! I would kindly ask you to address this comment on the hardcoded feet collision, before merging! |
removed hardcoded numbers
Hello @CarlottaSartore, here are the changes:
Please let me know if you think more changes are necessary. Also, apologies for the delay 😅 |
Everything looks in place, thanks for your contribution @akhilsathuluri :) |
Merging upstream changes with local
This is a draft PR for the newly added class which are bindings of
CoMoDo
withdrake
and an example showing how it works.The class follows almost exactly the same design of the
mujocoSimulator
class.I also added a helper class that bridges between any one coming from a different platform to make their URDFs compatible with drake and simplifies loading. However, this needs the
odio_urdf
from my repo: https://github.com/akhilsathuluri/odio_urdf and some additional dependencies, which needs to be handled seperately.For the sake of a common structure, I added the example in Jupyter too, but it is not comfortable to maintain it (especially when the JSON fails due to git merge issues). An alternative is: https://github.com/mwouts/jupytext
In the next push, I will have modified
include
files to add theangular_momentum
andcontact_force_regularisation
tasks sclaed by robots mass.(I changed the includes for faster prototyping.)
I have observed the same things as you mentioned today, that the robot falls down after a couple of steps in
mujoco
too.