Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(deps): update env-config-utils for fix #1240

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

10xLaCroixDrinker
Copy link
Member

Description

update env-config-utils

Motivation and Context

Adopt this fix americanexpress/env-config-utils#46

which is causing an erroneous log when OTel logging is not enabled

How Has This Been Tested?

started the application before and after the change both with and without OTel enabled

  • before with: logs erroneous message
  • before without: logs message correctly
  • after with: logs message clorrectly
  • after without: does not log erroneous message

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Eliminate erroneous message when not using OTel logging

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners January 18, 2024 19:14
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Size Change: 0 B

Total Size: 712 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 123 kB

compressed-size-action

@smackfu smackfu requested a review from a team January 18, 2024 19:23
@dogpatch626 dogpatch626 merged commit 076a769 into main Jan 18, 2024
9 checks passed
@dogpatch626 dogpatch626 deleted the bugfix/env-config-utils branch January 18, 2024 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants