Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(runTime): use relative urls for defaulted report variables #1194

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

smackfu
Copy link
Member

@smackfu smackfu commented Nov 27, 2023

Description

Changes the default development ONE_CLIENT_REPORTING_URL and ONE_CLIENT_CSP_REPORTING_URL to use relative URLs instead of URLs with a hostname.

Motivation and Context

Fixes #1193 by not using the internal docker IP address.

How Has This Been Tested?

Ran locally with one-app-runner using these updated variables and verified that report endpoints responded with 204 and printed reports to console.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

When running in Docker, Javascript errors should be printed to the console rather than not being reported.

@smackfu smackfu requested a review from a team November 27, 2023 18:23
@smackfu
Copy link
Member Author

smackfu commented Nov 27, 2023

Interestingly the documentation already says this is what is being used for the values:
https://github.com/americanexpress/one-app/blob/main/docs/api/server/Environment-Variables.md

Screenshot 2023-11-27 at 1 30 16 PM

@10xLaCroixDrinker 10xLaCroixDrinker enabled auto-merge (rebase) November 28, 2023 22:16
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 059df73 into americanexpress:main Nov 29, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default ONE_CLIENT_REPORTING_URL value does not work in Docker
3 participants