This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(runTime): use relative urls for defaulted report variables #1194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the default development ONE_CLIENT_REPORTING_URL and ONE_CLIENT_CSP_REPORTING_URL to use relative URLs instead of URLs with a hostname.
Motivation and Context
Fixes #1193 by not using the internal docker IP address.
How Has This Been Tested?
Ran locally with one-app-runner using these updated variables and verified that report endpoints responded with 204 and printed reports to console.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
When running in Docker, Javascript errors should be printed to the console rather than not being reported.