fix(one-app-server-bundler): remove excess (#619)

packages/one-app-server-bundler/__mocks__/node:fs.js

@@ -48,11 +48,11 @@ const fs = {
     files[filePath] = content;
   }),
 
-  rmdirSync: jest.fn((dirPath) => {
-    if (!files[dirPath]) {
-      throw new Error(`Couldn't delete dir ${dirPath}`);
+  rmSync: jest.fn((path, opts = {}) => {
+    if (!files[path] && !opts.force) {
+      throw new Error(`Couldn't delete file/dir ${path}`);
     }
-    delete files[dirPath];
+    delete files[path];
   }),
 
   mkdirSync: jest.fn(),

packages/one-app-server-bundler/__tests__/bin/__snapshots__/serve-module.spec.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports['serve-module adds to the existing module map 1'] = `
+exports[`serve-module adds to the existing module map 1`] = `
 "{
   \\"key\\": \\"--- omitted for development ---\\",
   \\"modules\\": {
@@ -36,7 +36,7 @@ exports['serve-module adds to the existing module map 1'] = `
 }"
 `;
 
-exports['serve-module adds to the existing module map without legacy when disableDevelopmentLegacyBundle is true 1'] = `
+exports[`serve-module adds to the existing module map without legacy when legacy bundle does not exist 1`] = `
 "{
   \\"key\\": \\"--- omitted for development ---\\",
   \\"modules\\": {
@@ -64,7 +64,7 @@ exports['serve-module adds to the existing module map without legacy when disabl
 }"
 `;
 
-exports['serve-module creates a module map when one does not exist 1'] = `
+exports[`serve-module creates a module map when one does not exist 1`] = `
 "{
   \\"key\\": \\"not-used-in-development\\",
   \\"modules\\": {
@@ -86,4 +86,4 @@ exports['serve-module creates a module map when one does not exist 1'] = `
 }"
 `;
 
-exports['serve-module should throw if the module doesn\'t have a version 1'] = '"No versioned bundles exist for module my-module-name"';
+exports[`serve-module should throw if the module doesn't have a version 1`] = `"No versioned bundles exist for module my-module-name"`;

packages/one-app-server-bundler/__tests__/bin/drop-module.spec.js

@@ -18,8 +18,8 @@ testing `on import` functionality needs 'require' in every tests */
 let fs = require('node:fs');
 
 jest.mock('node:fs');
-jest.mock('yargs', () => ({
-  argv: { _: ['my-module-name'] },
+jest.mock('node:util', () => ({
+  parseArgs: jest.fn(() => ({ positionals: ['my-module-name'] })),
 }));
 
 describe('drop-module', () => {
@@ -120,7 +120,7 @@ describe('drop-module', () => {
     expect(fs._.getFiles()).toHaveProperty('/mocked/static/modules/my-module-name');
     require('../../bin/drop-module');
 
-    expect(fs.rmdirSync).toHaveBeenCalledWith('/mocked/static/modules/my-module-name');
+    expect(fs.rmSync).toHaveBeenCalledWith('/mocked/static/modules/my-module-name', { recursive: true, force: true });
     expect(fs._.getFiles()).not.toHaveProperty('/mocked/static/modules/my-module-name');
   });
 

packages/one-app-server-bundler/__tests__/bin/serve-module.spec.js

@@ -15,25 +15,18 @@
 /* eslint-disable global-require --
 testing `on import` functionality needs 'require' in every tests */
 
-let fs = require('fs');
+let fs = require('node:fs');
 
-let rimraf;
-
-jest.mock('fs');
-jest.mock('../../utils/getConfigOptions', () => jest.fn(() => ({ disableDevelopmentLegacyBundle: false })));
+jest.mock('node:fs');
 
 const setup = (modulePath) => {
   jest.resetModules();
   jest.clearAllMocks();
-  jest.doMock('yargs', () => ({
-    argv: { _: [modulePath] },
-  }));
-  jest.doMock('rimraf', () => ({
-    sync: jest.fn(),
+  jest.doMock('node:util', () => ({
+    parseArgs: jest.fn(() => ({ positionals: [modulePath] })),
   }));
 
-  fs = require('fs');
-  rimraf = require('rimraf');
+  fs = require('node:fs');
 };
 
 describe('serve-module', () => {
@@ -78,7 +71,7 @@ describe('serve-module', () => {
       '/mocked/static/modules/my-module-name/1.0.0': {},
     });
     require('../../bin/serve-module');
-    expect(rimraf.sync).toHaveBeenCalledWith('/mocked/static/modules/my-module-name');
+    expect(fs.rmSync).toHaveBeenCalledWith('/mocked/static/modules/my-module-name', { recursive: true, force: true });
   });
 
   it('should remove an existing symlink and create a new one', () => {
@@ -159,9 +152,8 @@ describe('serve-module', () => {
     expect(fs._.getFiles()['/mocked/static/module-map.json']).toMatchSnapshot();
   });
 
-  it('adds to the existing module map without legacy when disableDevelopmentLegacyBundle is true', () => {
+  it('adds to the existing module map without legacy when legacy bundle does not exist', () => {
     process.env.NODE_ENV = 'development';
-    jest.mock('../../utils/getConfigOptions', () => jest.fn(() => ({ disableDevelopmentLegacyBundle: true })));
     fs._.setFiles({
       '../my-module-name/package.json': JSON.stringify({ name: 'my-module-name', version: '1.0.0' }),
       '/mocked/static/module-map.json': JSON.stringify({

packages/one-app-server-bundler/__tests__/utils/patchedCryptoHash.spec.js

@@ -11,7 +11,7 @@
  * or implied. See the License for the specific language governing permissions and limitations
  * under the License.
  */
-const crypto = require('crypto');
+const crypto = require('node:crypto');
 
 const createHashSpy = jest.spyOn(crypto, 'createHash');