-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Support #6
Conversation
Current master is missing |
@esteve I fixed master and rebased this branch, please pull. |
I've ticked the todo items above, I think we should merge this and fix those in separate prs. |
@@ -23,7 +23,7 @@ def get_environment_hook_template_path(name): | |||
|
|||
|
|||
def get_package_level_template_names(): | |||
return ['local_setup.%s.in' % ext for ext in ['bash', 'sh', 'zsh']] | |||
return ['local_setup.%s.in' % ext for ext in ['bash', 'sh', 'zsh', 'bat']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: insert in alphabetical order. Same two more times below.
+1 |
lgtm |
This does not include the prefix level setup.bat template.
This pull request adds support for Windows by providing and exposing
.bat
versions of the.sh
prefix level and package levellocal_setup
andsetup
template files.There is still work to be done here:
The prefix levelConvert prefix level setup.bat file to batch #8setup.bat.in
still contains shell code and needs to be converted to batchThe prefix levelChange sorting of environment hooks #7local_setup.bat.in
still does not order environment hooks by file nameThe isolated install'sTest isolated install on Windows ros2/ros2#17local_setup.bat.in
needs to be testedConnects to ros2/ros2#9