Remove match args to allow pydocstyle defaults

[Arnatious]

Changes --match to use pydocstyle default

• Current: .*\.py
• New (Default): (?!test_).*\.py
  Result: don't check 'test_*' files for documentation

Changes --match-dir to use pydocstyle default

• Current: [^\._].*
• New (Default): [^\.].*
  Result: include private ('_*') package directories in checks

Signed-off-by: Ted Kern ted.kern@canonical.com

[kyrofa]

I'm in support of using the default behavior, although admittedly this may have wide-ranging ramifications if non-public modules were never linted. I think this is technically correct, but I also don't like the idea of code suddenly starting to fail the linter without the code changing. We might consider exposing this as an option instead. Curious to get other thoughts.

[dirk-thomas]

I rebased your branch since the target branch has changed quite a bit since the fork.

A first CI build on Linux to see how the modified config affect the result for the existing code:

[dirk-thomas]

I also don't like the idea of code suddenly starting to fail the linter without the code changing.

This is certainly not something I would propose to be backported. But changing the default in the rolling distro is imo acceptable. Especially since the chances that it affects existing code is rather low (considering that there is not a single new warning due to this change in the whole ros2.repos file).

So I am planning to merge this within a day if there are no strong opinions not to accept the patch as is.

[kyrofa]

So I am planning to merge this within a day if there are no strong opinions not to accept the patch as is.

Not from me, you convinced me with:

there is not a single new warning due to this change in the whole ros2.repos file