Resolve some todos #103
Resolve some todos #103
Conversation
| @@ -134,8 +134,7 @@ if(NOT _exported_library_names STREQUAL "") | |||
| endwhile() | |||
| endif() | |||
|
|
|||
| # deduplicate @PROJECT_NAME@_LIBRARIES | |||
| # TODO deduplicate @PROJECT_NAME@_LIBRARIES | |||
There was a problem hiding this comment.
should we associate names to each TODO like we do in c++ ?
e330a77 to
372f81e
Compare
| @@ -133,5 +133,3 @@ function(_ament_add_nose_test testname path) | |||
| LABELS "nose" | |||
| ) | |||
| endfunction() | |||
|
|
|||
| # TODO provide function to register all found tests separately | |||
There was a problem hiding this comment.
I'm not sure what this TODO means exactly, and where has the function it refers to been implemented. Can you provide a pointer to that function ?
There was a problem hiding this comment.
The idea was to introspect nosetest and register each individual test function as a separate CTest. I don't think we will purpose the idea though since that make reporting the results in separate JUnit files much more difficult and the runtime would be worse since each test would use a separate Python interpreter.
There was a problem hiding this comment.
Could such a function provide the ability to flag / label test functions independently (in the vein of what is suggested in ros2/build_farmer#41 (comment)) ?
There was a problem hiding this comment.
Tests can already be labels within Python. No need for CTest to get involved for that.
There was a problem hiding this comment.
👍 cool
@nuclearsandwich FYI
| install(CODE | ||
| "execute_process( | ||
| COMMAND | ||
| \"${PYTHON_EXECUTABLE}\" \"-m\" \"compileall\" |
There was a problem hiding this comment.
Question: should this accept a custom executable like add_nose_test ? (same below)
There was a problem hiding this comment.
It could, but until there is a use case when this is needed I wouldn't implement it.
There was a problem hiding this comment.
fair enough, windows will tell us soon enough if we need to pass a debug interpreter here
|
Looks good to me then, thanks @dirk-thomas for the explanations |
TODOsTODOs to a line with a comment (rather than an empty line)file(GLOB LIST_DIRECTORIES ...)