Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom periods in seconds in timeInHex #24

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Conversation

amdelamar
Copy link
Owner

Instead of forcing 30s default periods, this
change allows users to specify their own
period value using timeInHex(time, period).

Period must be positive non-zero integer.

Fixes #14

Instead of forcing 30s default periods, this
change allows users to specify their own
period value using timeInHex(time, period).

Period must be positive non-zero integer.

Fixes #14
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #24 into master will decrease coverage by 0.59%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
- Coverage     94.48%   93.89%   -0.60%     
- Complexity       46       47       +1     
============================================
  Files             5        5              
  Lines           127      131       +4     
  Branches         21       22       +1     
============================================
+ Hits            120      123       +3     
  Misses            7        7              
- Partials          0        1       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/amdelamar/jotp/OTP.java 88.57% <80.00%> (-0.83%) 21.00 <2.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9c809...3f99e6f. Read the comment docs.

@amdelamar amdelamar merged commit f0ab0d4 into master Sep 20, 2020
@amdelamar amdelamar deleted the customPeriod branch September 20, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add period parameter for TOTP
1 participant