Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set immutable variables as final #23

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Set immutable variables as final #23

merged 1 commit into from
Aug 30, 2020

Conversation

amdelamar
Copy link
Owner

No description provided.

@amdelamar amdelamar self-assigned this Aug 30, 2020
@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage     94.48%   94.48%           
  Complexity       46       46           
=========================================
  Files             5        5           
  Lines           127      127           
  Branches         21       21           
=========================================
  Hits            120      120           
  Misses            7        7           
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/amdelamar/jotp/OTP.java 89.39% <87.50%> (ø) 20.00 <3.00> (ø)
src/main/java/com/amdelamar/jotp/type/HOTP.java 100.00% <100.00%> (ø) 16.00 <0.00> (ø)
src/main/java/com/amdelamar/jotp/type/TOTP.java 100.00% <100.00%> (ø) 8.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc90e1...d174ea5. Read the comment docs.

@amdelamar amdelamar merged commit 5a9c809 into master Aug 30, 2020
@amdelamar amdelamar deleted the final branch August 30, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant