Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate two methods #16

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Deprecate two methods #16

merged 1 commit into from
Nov 8, 2019

Conversation

amdelamar
Copy link
Owner

timeInHex() and random(), as both are not critical to keep anyway.

Will remove them in the next minor release. #13

timeInHex() and random(), as both are not critical to keep anyway.

Will remove them in the next minor release. #13
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #16 into master will decrease coverage by 5.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage       100%   94.48%   -5.52%     
+ Complexity       50       46       -4     
============================================
  Files             5        5              
  Lines           127      127              
  Branches         21       21              
============================================
- Hits            127      120       -7     
- Misses            0        7       +7
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/amdelamar/jotp/OTP.java 89.39% <ø> (-10.61%) 20 <0> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f7a5f6...db4b46d. Read the comment docs.

@amdelamar amdelamar merged commit fe804a4 into master Nov 8, 2019
@amdelamar amdelamar deleted the deprecateMethods branch November 8, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant