Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base32 secret should be uppercased #12

Closed
amdelamar opened this issue Jul 25, 2019 · 0 comments
Closed

Base32 secret should be uppercased #12

amdelamar opened this issue Jul 25, 2019 · 0 comments
Assignees
@amdelamar
Labels
bug

Comments

@amdelamar
Copy link
Owner 

// this generated code
OTP.create("MFRGGZDFMZTWQ2LK", OTP.timeInHex(), 6, Type.TOTP)

// does not equal this code
OTP.create("mfrggzdfmztwq2lk", OTP.timeInHex(), 6, Type.TOTP)

Secret should always be uppercased.
@amdelamar amdelamar added the bug label Jul 25, 2019
@amdelamar amdelamar self-assigned this Jul 25, 2019
amdelamar added a commit that referenced this issue Nov 8, 2019
@amdelamar
Set Base32 Secret toUppercase()
31c2a72 
Base32 secret should always be uppercased if not already. #12
@amdelamar amdelamar mentioned this issue Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amdelamar amdelamar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amdelamar