Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: on a brand new install timeline doesn't auto refresh #516

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix: on a brand new install timeline doesn't auto refresh #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/components/AppFrame.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- nav goes here -->
<NavBar />

<v-content>
<v-main>
<v-container
id="container"
class="pa-0 ma-0"
Expand All @@ -14,7 +14,7 @@
<p>App page content goes here...</p>
</slot>
</v-container>
</v-content>
</v-main>

<v-footer
app
Expand Down
4 changes: 2 additions & 2 deletions src/views/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<v-content class="body">
<v-main class="body">
<v-container
id="container"
fluid
Expand Down Expand Up @@ -77,7 +77,7 @@
</v-col>
</v-row>
</v-container>
</v-content>
</v-main>
</template>

<script>
Expand Down
32 changes: 16 additions & 16 deletions src/views/Timeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
class="pa-0 ma-0"
>
<infinite-loading
v-if="!isBottomSpinnerVisible"
direction="top"
@infinite="infiniteHandlerTop"
v-observe-visibility="topSpinnerVisibilityChanged"
>
<span slot="no-more">
There are no new timeline events.
Expand Down Expand Up @@ -145,9 +145,9 @@
>
<v-col cols="7">
<v-tooltip bottom>
<template>
<template #activator="{ on: tooltip }">
<v-btn
v-on="on"
v-on="tooltip"
fab
color="success lighten-2"
class="mx-2"
Expand All @@ -158,9 +158,9 @@
<span>Looks fine</span>
</v-tooltip>
<v-tooltip bottom>
<template>
<template #activator="{ on: tooltip }">
<v-btn
v-on="on"
v-on="tooltip"
color="error lighten-2"
fab
class="mx-2"
Expand All @@ -173,32 +173,32 @@
</v-col>
<v-col cols="1">
<v-tooltip bottom>
<template>
<template #activator="{ on: tooltip }">
<v-btn
icon
v-on="on"
v-on="tooltip"
>
<v-icon>mdi-heart</v-icon>
</v-btn>
</template>
<span>Save to Favorites</span>
</v-tooltip>
<v-tooltip bottom>
<template>
<template #activator="{ on: tooltip }">
<v-btn
icon
v-on="on"
v-on="tooltip"
>
<v-icon>mdi-pen</v-icon>
</v-btn>
</template>
<span>Edit event details</span>
</v-tooltip>
<v-tooltip bottom>
<template>
<template #activator="{ on: tooltip }">
<v-btn
icon
v-on="on"
v-on="tooltip"
>
<v-icon>mdi-share-variant</v-icon>
</v-btn>
Expand Down Expand Up @@ -257,7 +257,7 @@
</v-list-item>
<infinite-loading
@infinite="infiniteHandlerBottom"
v-observe-visibility="bottomSpinnerVisibilityChanged"
v-if="!isTopSpinnerVisible"
>
<span slot="no-more">
There are no more timeline events.
Expand Down Expand Up @@ -295,7 +295,7 @@ export default {
imageURL: {}, // map[id, fullURL] - maps unique event id to their full thumbnail URLs
isImageLoaded: [],
on: true,
isBottomSpinnerVisible: false // flags whether the timeline is in the process of loading data
isTopSpinnerVisible: true // flags whether the timeline is in the process of loading data
}
},
created () {
Expand Down Expand Up @@ -353,9 +353,9 @@ export default {
console.debug('getNextTimelinePage received data', { timelineEvents }) // eslint-disable-line no-console
return timelineEvents
},
async bottomSpinnerVisibilityChanged (isVisible, entry) {
this.isBottomSpinnerVisible = isVisible
console.debug(`bottomSpinnerVisibilityChanged: ${isVisible}`) // eslint-disable-line no-console
async topSpinnerVisibilityChanged (isVisible, entry) {
this.isTopSpinnerVisible = isVisible
console.debug(`topSpinnerVisibilityChanged: ${isVisible}`) // eslint-disable-line no-console
},
async infiniteHandlerTop ($state) {
try {
Expand Down