fix: installed pwa does not pick up new version, closes #298

[Alexander-Bliznyuk]

No description provided.

[commit-lint]

Bug Fixes

• installed pwa does not pick up new version, closes Installed PWA does not pick up new version #298 (128fa2f)
• merge branch 'master' into 'pick-up-new-version' (d8765d1)

Contributors

@

[ivelin]

Hi @Alexander-Bliznyuk , I noticed that the version displayed in the UI is not the version of the release but the previous version. Its likely a bug in the release script. It probably updates package.json after release instead of before. Do you have time to look into it?

[Alexander-Bliznyuk]

Hi @Alexander-Bliznyuk , I noticed that the version displayed in the UI is not the version of the release but the previous version. Its likely a bug in the release script. It probably updates package.json after release instead of before. Do you have time to look into it?

Hi, I will have a look.

[ivelin]

Great, thank you!

[ivelin]

This PR shows a conflict in src/store/index.js
Could you please submit an update that resolves it?

[Alexander-Bliznyuk]

This PR shows a conflict in src/store/index.js
Could you please submit an update that resolves it?

This is due to the previous PR. Tomorrow I will fix all the issues.

[ivelin]

Спасибо!

…

On Tue, Apr 14, 2020 at 12:23 PM Alexander-Bliznyuk < ***@***.***> wrote: This PR shows a conflict in src/store/index.js Could you please submit an update that resolves it? This is due to the previous PR. Tomorrow I will fix all the issues. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#324 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARBUFPL7UVCVWTIKZIA3WDRMSL2PANCNFSM4MHSNGPQ> .

[ivelin]

Good morning, @Alexander-Bliznyuk . Just checking whether you are blocked and waiting on me?

[Alexander-Bliznyuk]

Sorry for the delay.
I resolved the conflict, but couldn't reproduce the problem with outdated version displayed in the UI. What steps can I go through to reveal the bug?
semantic-release is configured to push updated package.json to Github and it actually gets included in the commits alongside CHANGELOG.md.

[Alexander-Bliznyuk]

Спасибо!
…
On Tue, Apr 14, 2020 at 12:23 PM Alexander-Bliznyuk < @.***> wrote: This PR shows a conflict in src/store/index.js Could you please submit an update that resolves it? This is due to the previous PR. Tomorrow I will fix all the issues. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#324 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARBUFPL7UVCVWTIKZIA3WDRMSL2PANCNFSM4MHSNGPQ .

Заповядайте!

[ivelin]

:)

[ivelin]

Sorry for the delay.
I resolved the conflict, but couldn't reproduce the problem with outdated version displayed in the UI. What steps can I go through to reveal the bug?
semantic-release is configured to push updated package.json to Github and it actually gets included in the commits alongside CHANGELOG.md.

It is not obvious to me where the bug is. I also though the sem release script is fine. Maybe it was a one time issues with the git commit plugin. I will keep an eye on it and raise a flag if it persists.

[ivelin]

🎉 This PR is included in version 2.2.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀