Create new stanza encoding instance for each thread #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-mateen
previously approved these changes
Aug 7, 2023
adam-mateen
reviewed
Aug 7, 2023
a9d50b9 to
c393fa9
Compare
c393fa9 to
d06bc0d
Compare
adam-mateen
approved these changes
Aug 7, 2023
|
Vulnerability checks and integration test failures are unrelated to change. |
sethAmazon
approved these changes
Aug 7, 2023
sky333999
approved these changes
Aug 7, 2023
sky333999
pushed a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit b8f0f42)
This was referenced Sep 21, 2023
lisguo
pushed a commit
to lisguo/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The shared buffer in the stanza decoder was causing a concurrency issue where the buffer would get updated by multiple separate threads. This meant that some messages were getting corrupted after decoding and some messages were getting completely replaced. This resulted in duplicates and invalid logs getting passed through the collector.
Link to tracking Issue: open-telemetry#24980
Testing: Reproduced the issue with a generator that established multiple TCP connections and sent to the tcplogreceiver concurrently. No longer seeing the issue after changing the
helper.Encodinginstantiation to each thread instead of using a shared one.