Merge elm_ats updates to master #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialization code to protected coordinator_init function
… now; modified ELM_ATSDriver::advance to call Coordinator::advance for each single timestep
…ssed correctly, ATS pressure initialization from ELM water content, etc.
Adds BUILD_ELM_ATS_API flag to turn on/off building of ELM-ATS API object files.
|
Ready for review on the ATS side I think @ecoon - testing out the amanzi bootstrap changes now |
ecoon
reviewed
Jul 21, 2024
src/executables/CMakeLists.txt
Outdated
|
|
||
| # set this here for now | ||
| # add option to bootstrap before completion | ||
| if (BUILD_ELM_ATS_API) |
There was a problem hiding this comment.
this probably needs to be updated to ENABLE_ELM_ATS_API now, otherwise this PR is ready to go.
There was a problem hiding this comment.
Done with c330f4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to replace #216. Merging a branch with elm_ats updates which has been rebased to master and had calls to boost removed.
A few steps still needed before merge:
Also have noticed a single test fail on macOS M2 w/ gcc14 and openmpi 5.0.3.