Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the implementation of Api.getPackagesForUser() leading to empty package list. #3

Closed
amaa-99 opened this issue Jul 25, 2023 · 0 comments · Fixed by #5
Closed

Bug in the implementation of Api.getPackagesForUser() leading to empty package list. #3

amaa-99 opened this issue Jul 25, 2023 · 0 comments · Fixed by #5
Assignees
@amaa-99

Comments

@amaa-99
Copy link
Owner

amaa-99 commented Jul 25, 2023

Describe the bug
There's an error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser(), thus leading to an execution error and consequently to an empty package list getting returned.

Firewall Logs

Smartphone (please complete the following information):

  • Device: Any.
  • Android OS: 6 and probably others.

Additional context
This can be observed right at application startup (or any other times this method gets called).
@amaa-99 amaa-99 self-assigned this Jul 25, 2023
amaa-99 pushed a commit that referenced this issue Jul 25, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
3728571 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
@amaa-99 amaa-99 linked a pull request Jul 25, 2023 that will close this issue
[Issue #3] Bug in the implementation of Api.getPackagesForUser() le… #5
Merged
amaa-99 pushed a commit that referenced this issue Jul 25, 2023
@amaa-99
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
0d9461b 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Jul 28, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
1433e79 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 9, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
7fe9332 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 9, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
48416bb 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 9, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
617e995 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 9, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
89f8a83 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 10, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
c957e0c 
…ading to empty package list.

Implemented the new Api.getApplicationIcon() method and replaced the calls to Api.getPackagesForUser() in the LogRecyclerViewAdapter with this one.
This both works around the unsupported 'pm list packages -U' issue, and fixes the lag when opening the log view due to the overhead of running 'pm list' in a shell.
amaa-99 pushed a commit that referenced this issue Aug 10, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
b3bf307 
…ading to empty package list.

Changed the getApps() implementation to only call getPackagesForUser() in case supportDual is enabled.
This avoids the problems with the unsupported 'pm list packages -U' issue in that location in case the supportDual is not enabled, and reduces the lag when opening the application list view due to the overhead of running 'pm list' in a shell.
amaa-99 pushed a commit that referenced this issue Aug 10, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
327a5b4 
…ading to empty package list.

Implemented the new Api.getApplicationIcon() method and replaced the calls to Api.getPackagesForUser() in the LogRecyclerViewAdapter with this one.
This both works around the unsupported 'pm list packages -U' issue, and fixes the lag when opening the log view due to the overhead of running 'pm list' in a shell.
amaa-99 pushed a commit that referenced this issue Aug 10, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
491df0b 
…ading to empty package list.

Fixed the error in the syntax of the 'pm list packages' command executed in the Api.getPackagesForUser() leading to an execution error and consequently to an empty package list getting returned.
amaa-99 pushed a commit that referenced this issue Aug 10, 2023
* [Issue #3] Bug in the implementation of Api.getPackagesForUser() le…
265460e 
…ading to empty package list.

Changed the getApps() implementation to only call getPackagesForUser() in case supportDual is enabled.
This avoids the problems with the unsupported 'pm list packages -U' issue in that location in case the supportDual is not enabled, and reduces the lag when opening the application list view due to the overhead of running 'pm list' in a shell.
amaa-99 pushed a commit that referenced this issue Aug 19, 2023
@ukanth
Merge pull request ukanth#1338 from amaa-99/3-bug-in-the-implementati…
9612d6f 
…on-of-apigetpackagesforuser-leading-to-empty-package-list

[Issue #3] Bug in the implementation of Api.getpackagesForUser() leading to empty package list.
@amaa-99 amaa-99 mentioned this issue Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaa-99 amaa-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #3] Bug in the implementation of Api.getPackagesForUser() le… amaa-99/afwall
1 participant
@amaa-99