feat: Pico Motion Trackers body tracking support #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
requested changes
Jan 30, 2025
zmerp
requested changes
Jan 30, 2025
|
LGTM, it just needs a rebase |
f0cc741 to
f6cc85c
Compare
zmerp
requested changes
Feb 1, 2025
There was a problem hiding this comment.
I think that for lobby_interaction_sources (in client_openxr lib.rs) you can add body tracking source for Pico, otherwise you did all the work of adding lobby support for nothing. the reason why we have body tracking for Meta for lobby and then don't use it is because that was the outcome of some refactoring. Before we just exposed to the lobby whatever inputs were active in the last stream session, but then we switched to have a separate and constant input set for lobby. Since multimodal and body tracking are in conflict on Meta, I chose to expose multimodal instead of body tracking. For pico there is no such conflict (also because Pico doesn't support multimodal)
zmerp
requested changes
Feb 1, 2025
zmerp
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2072. Tested with two PMT on Pico OS 5.12.0S.