refactor: ♻️ Move client graphics code to separate crate #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
The changes themselves LGTM, I just don't really understand moving stuff to a separate crate because client and server graphics code will always be pretty different (because they need to do fundamentally different things) and especially with wgpu there's very little boilerplate to save by having shared helpers.
|
The idea was in the future to move server code to wgpu. Things like Foveated encoding need to share how the parameters are calculated (at the moment we straight up duplicate the code), and other things like wgpu initialization could be partially shared |
|
Yea I just realized a certain amount of stuff can be shared for FFE, but apart from that idk. |
zmerp
added a commit
that referenced
this pull request
Jan 18, 2025
zmerp
added a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.