Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(everything): Automatically assign controller and headset info based on the client-provided string #2453

Conversation

shinyquagsire23
Copy link
Contributor

  • Adds Quest Pro controller models to SteamVR backend (and an override option for that)
  • Move alvr_client_core::platform to alvr_common so it can be used in server_core
  • Allow parsing Platform from its to_string() value, to allow Platform usage in server_core when the client connects
  • A bit of simplification on the OpenVR properties, specifically grouping common icon settings into a separate match statement so it isn't duplicated 4 times for Quest/Rift controllers

@shinyquagsire23 shinyquagsire23 requested a review from zmerp October 12, 2024 01:02
@zmerp
Copy link
Member

zmerp commented Oct 12, 2024

There are quite a few compilation errors here. First of all we should discuss if moving the platform to the common crate is a good idea. My initial idea was no, because you are adding more dependencies to alvr_common. But on second through i think it's ok. The only dependencies are jni and ndk_context and these can be gated to android. I'd say as a fist step, you should move all Platform related stuff to alvr_common, in another PR. Then when merged we rebase this one.

@zmerp
Copy link
Member

zmerp commented Oct 20, 2024

I'm going to move the platform stuff to a new crate alvr_system_info, once the the queue of PRs got cleared up a bit

@shinyquagsire23
Copy link
Contributor Author

gonna go ahead and close this and do it a bit more piecewise (ie, Quest Pro controller PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants