-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): ✨ Expose server version from client_core #2387
Conversation
Tested it on visionOS and it seems to work fine, defaults to "20.11.0" on older versions but it seems like |
@shinyquagsire23 What do you mean "defaults to "20.11.0" on older versions"? What did you try? |
@zarik5 I tested streamer 20.9 and 20.10 from Releases with the patched client_core and it always returned the string "20.11.0" |
Now I remember why. This is actually caused by sloppy session extrapolation. Thankfully i can implement a fix and this will work retroactively for previous server builds. |
Do you mean knowing that the version is <= 20.11 is good enough and the fix in the server will be implemented later? |
No, i mean that the server version is already passed correctly but the client mistakenly overwrites and loses the value, because of faulty session extrapolation |
that's what I was wondering, odd choice to not directly add the fix to the pr then |
I was thinking about that. You may be right. Anyway I'll make another PR tomorrow |
honestly for visionOS it kinda works out anyhow, because the issue I thought I needed the versions to patch over (controllers being rotated) was fixed with the client_core update anyhow. Though I might disable the hand skeleton hysteresis on older versions where SteamVR input 2.0 gets set true by default w/o the streamer having those settings present |
The new C API is
alvr_get_server_version
which works similarly toalvr_get_settings_json
. The value can be obtained only after server connection, and the string length can be obtained by passing a null buffer.