fix(client_core): 🐛 Fix staging texture resolution #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
approved these changes
Sep 6, 2024
|
Can you explain more about this, what was happening before and whats the fix about ? Its effect on decoder latency ? I think this will increase the latency even more |
|
@ShootingKing-AM This has nothing to do with latency. it's simply a bug where the decoder output has a certain size but we render it to a texture with half the width. OpenGL itself doesn't care about these bugs. |
|
@The-personified-devil it did |
|
@zarik5 it did cause I edited your message to do it |
|
gotcha |
zmerp
added a commit
that referenced
this pull request
Sep 10, 2024
Merged
zmerp
added a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2374