Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Fix and rework logging #2351

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix: 🐛 Fix and rework logging #2351

merged 2 commits into from
Aug 27, 2024

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Aug 22, 2024 •
edited
Loading

This PR achieves multiple things:

  • Fix debug group filter not actually filtering logs to file or stdout
  • Use log target instead of message prefix to filter debug groups
  • Make debug groups separate events
  • Make logging to dashboard or file more legible
  • Add server impl (SteamVR) group logs

@The-personified-devil
Copy link
Collaborator

I mean I didn't catch it in code review either, but how do you keep managing to not test stuff

@zmerp zmerp force-pushed the more-server-tracing branch from 7824642 to 834ee11 Compare August 22, 2024 20:41
@zmerp zmerp requested a review from KyleCarr August 26, 2024 15:43
The-personified-devil
The-personified-devil requested changes Aug 26, 2024
View reviewed changes
alvr/server_openvr/cpp/alvr_server/Controller.cpp Outdated Show resolved Hide resolved
alvr/dashboard/src/dashboard/components/logs.rs Show resolved Hide resolved
alvr/server_openvr/cpp/alvr_server/Controller.cpp Outdated Show resolved Hide resolved
alvr/server_core/src/connection.rs Outdated Show resolved Hide resolved
@zmerp zmerp merged commit 7f4e63b into master Aug 27, 2024
9 checks passed
@zmerp zmerp deleted the more-server-tracing branch August 27, 2024 18:24
zmerp added a commit that referenced this pull request Sep 10, 2024
@zmerp
fix: 🐛 Fix and rework logging (#2351)
b99124a 
* fix: 🐛 Fix and rework logging

* Address review comments
@zmerp zmerp mentioned this pull request Sep 10, 2024
Merged
zmerp added a commit that referenced this pull request Sep 10, 2024
@zmerp
fix: 🐛 Fix and rework logging (#2351)
c1dee82 
* fix: 🐛 Fix and rework logging

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-personified-devil The-personified-devil The-personified-devil approved these changes

@KyleCarr KyleCarr Awaiting requested review from KyleCarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmerp @The-personified-devil