Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server_core): 🐛 Fix deadlock on button set init #2330

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Aug 15, 2024

No description provided.

@zmerp zmerp force-pushed the fix-server-core-deadlock branch from 7099063 to fd1e6aa Compare August 15, 2024 23:40
Copy link
Collaborator

@The-personified-devil The-personified-devil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, let's hope it doesn't introduce some random bug with the mappings somehow changing over time

@zmerp
Copy link
Member Author

zmerp commented Aug 15, 2024

it's true it might, not currently, but it's possible protocol-wise. I can fix that

@zmerp zmerp force-pushed the fix-server-core-deadlock branch from 8a47a04 to 03d20dd Compare August 16, 2024 00:12
@zmerp zmerp merged commit 1c3eba5 into master Aug 16, 2024
9 checks passed
@zmerp zmerp deleted the fix-server-core-deadlock branch August 16, 2024 00:30
failboat78 pushed a commit to failboat78/ALVR that referenced this pull request Aug 17, 2024
* fix(server_core): 🐛 Fix deadlock on button set init

* Don't pick up updated emulation_mode
szneqz pushed a commit to szneqz/ALVR that referenced this pull request Aug 21, 2024
* fix(server_core): 🐛 Fix deadlock on button set init

* Don't pick up updated emulation_mode
zmerp added a commit that referenced this pull request Sep 10, 2024
* fix(server_core): 🐛 Fix deadlock on button set init

* Don't pick up updated emulation_mode
zmerp added a commit that referenced this pull request Sep 10, 2024
* fix(server_core): 🐛 Fix deadlock on button set init

* Don't pick up updated emulation_mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants