Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): 🚀 Update manifest for AppLab #2146

Merged
merged 1 commit into from
May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,6 @@ ALVR-Launcher

#allows adding CMake files for some IDEs to parse C++ files correctly
CMakeLists.txt
cmake-build-debug/
cmake-build-debug/

*.jks
12 changes: 4 additions & 8 deletions alvr/client_openxr/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ndk-context = "0.1"

[package.metadata.android]
package = "alvr.client"
install_location = "auto"
build_targets = ["aarch64-linux-android"]
runtime_libs = "../../deps/android_openxr"

Expand All @@ -41,7 +42,7 @@ keystore_password = "alvrclient"

[package.metadata.android.sdk]
min_sdk_version = 26
target_sdk_version = 29
target_sdk_version = 32

[[package.metadata.android.uses_feature]]
name = "android.hardware.microphone"
Expand All @@ -64,8 +65,6 @@ name = "android.permission.INTERNET"
[[package.metadata.android.uses_permission]]
name = "android.permission.RECORD_AUDIO"
[[package.metadata.android.uses_permission]]
name = "android.permission.WAKE_LOCK"
[[package.metadata.android.uses_permission]]
name = "org.khronos.openxr.permission.OPENXR"
[[package.metadata.android.uses_permission]]
name = "org.khronos.openxr.permission.OPENXR_SYSTEM"
Expand All @@ -75,7 +74,7 @@ name = "org.khronos.openxr"
authorities = "org.khronos.openxr.runtime_broker;org.khronos.openxr.system_runtime_broker"

[package.metadata.android.application]
debuggable = true
debuggable = false
theme = "@android:style/Theme.Black.NoTitleBar.Fullscreen"
# icon = todo
label = "ALVR"
Expand Down Expand Up @@ -107,9 +106,6 @@ required = false
[[package.metadata.android.uses_feature]]
name = "com.oculus.software.body_tracking"
required = false
[[package.metadata.android.uses_feature]]
name = "com.oculus.experimental.enabled"
required = false
[[package.metadata.android.uses_permission]]
name = "com.oculus.permission.EYE_TRACKING"
[[package.metadata.android.uses_permission]]
Expand All @@ -125,7 +121,7 @@ name = "com.oculus.intent.category.VR"
value = "vr_only"
[[package.metadata.android.application.meta_data]]
name = "com.oculus.supportedDevices"
value = "all"
value = "quest|quest2|questpro"
[[package.metadata.android.application.meta_data]]
name = "com.oculus.vr.focusaware"
value = "true"
Expand Down
12 changes: 6 additions & 6 deletions alvr/client_openxr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@ pub fn entry_point() {
| Platform::Quest2
| Platform::Quest3
| Platform::QuestPro
| Platform::QuestUnknown => "quest",
Platform::PicoNeo3 | Platform::Pico4 => "pico",
Platform::Yvr => "yvr",
Platform::Lynx => "lynx",
_ => "generic",
| Platform::QuestUnknown => "_quest",
Platform::PicoNeo3 | Platform::Pico4 => "_pico",
Platform::Yvr => "_yvr",
Platform::Lynx => "_lynx",
_ => "",
};
let xr_entry = unsafe {
xr::Entry::load_from(Path::new(&format!("libopenxr_loader_{loader_suffix}.so"))).unwrap()
xr::Entry::load_from(Path::new(&format!("libopenxr_loader{loader_suffix}.so"))).unwrap()
};

#[cfg(target_os = "android")]
Expand Down
8 changes: 7 additions & 1 deletion alvr/xtask/src/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,13 @@ pub fn build_android_client(profile: Profile) {
sh.create_dir(&build_dir).unwrap();

// Create debug keystore (signing will be overwritten by CI)
if matches!(profile, Profile::Release | Profile::Distribution) {
if env::var(format!(
"CARGO_APK_{}_KEYSTORE",
profile.to_string().to_uppercase()
))
.is_err()
&& matches!(profile, Profile::Release | Profile::Distribution)
{
let keystore_path = build_dir.join("debug.keystore");
if !keystore_path.exists() {
let keytool = PathBuf::from(env::var("JAVA_HOME").unwrap())
Expand Down
22 changes: 13 additions & 9 deletions alvr/xtask/src/dependencies.rs
Original file line number Diff line number Diff line change
Expand Up @@ -287,14 +287,14 @@ fn get_android_openxr_loaders() {
command::download_and_extract_zip(url, &temp_dir).unwrap();
fs::copy(
temp_dir.join(source_dir).join("libopenxr_loader.so"),
destination_dir.join(format!("libopenxr_loader_{name}.so")),
destination_dir.join(format!("libopenxr_loader{name}.so")),
)
.unwrap();
fs::remove_dir_all(&temp_dir).ok();
}

get_openxr_loader(
"generic",
"",
&format!(
"https://github.com/KhronosGroup/OpenXR-SDK-Source/releases/download/{}",
"release-1.0.27/openxr_loader_for_android-1.0.27.aar",
Expand All @@ -303,25 +303,25 @@ fn get_android_openxr_loaders() {
);

get_openxr_loader(
"quest",
"_quest",
"https://securecdn.oculus.com/binaries/download/?id=7092833820755144", // version 60
"OpenXR/Libs/Android/arm64-v8a/Release",
);

get_openxr_loader(
"pico",
"_pico",
"https://sdk.picovr.com/developer-platform/sdk/PICO_OpenXR_SDK_220.zip",
"libs/android.arm64-v8a",
);

get_openxr_loader(
"yvr",
"_yvr",
"https://developer.yvrdream.com/yvrdoc/sdk/openxr/yvr_openxr_mobile_sdk_1.0.0.zip",
"yvr_openxr_mobile_sdk_1.0.0/OpenXR/Libs/Android/arm64-v8a",
);

get_openxr_loader(
"lynx",
"_lynx",
"https://portal.lynx-r.com/downloads/download/16", // version 1.0.0
"jni/arm64-v8a",
);
Expand All @@ -346,9 +346,13 @@ pub fn build_android_deps(skip_admin_priv: bool) {
cmd!(sh, "rustup target add i686-linux-android")
.run()
.unwrap();
cmd!(sh, "cargo install cargo-apk cargo-ndk cbindgen")
.run()
.unwrap();
cmd!(sh, "cargo install cargo-ndk cbindgen").run().unwrap();
cmd!(
sh,
"cargo install --git https://github.com/zarik5/cargo-apk cargo-apk"
)
.run()
.unwrap();

get_android_openxr_loaders();
}
Loading