Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass RATSIGNAL as command parameter #51

Closed
alterNERDtive opened this issue Jul 31, 2020 · 4 comments
Closed

Pass RATSIGNAL as command parameter #51

alterNERDtive opened this issue Jul 31, 2020 · 4 comments
Assignees
@alterNERDtive
Labels
enhancement New feature or request RatAttack

Comments

@alterNERDtive
Copy link
Owner

VoiceAttack β 1.8.6.5 supports this.

Leave current way of passing through a file in, mark as deprecated.
@alterNERDtive alterNERDtive added enhancement New feature or request RatAttack labels Jul 31, 2020
@alterNERDtive alterNERDtive added this to the 3.1 milestone Jul 31, 2020
@alterNERDtive alterNERDtive self-assigned this Jul 31, 2020
@alterNERDtive
Copy link
Owner Author

https://voiceattack.com/changes.aspx?type=beta

alterNERDtive added a commit that referenced this issue Jul 31, 2020
@alterNERDtive
RatAttack: deprecated passing RATSIGNALs through the pipe file
7c9f6c4 
see #51
@alterNERDtive
Copy link
Owner Author

Basically done, waiting for next VA release.

@alterNERDtive alterNERDtive added done implemented, but not merged into release yet and removed done implemented, but not merged into release yet labels Jul 31, 2020
@alterNERDtive
Copy link
Owner Author

Turns out invoking commands from the command line is not thread safe and can run havok all over your parameters if invoked in rapid succession. Will have to halt this for now.

@alterNERDtive alterNERDtive modified the milestones: 3.1, future Jul 31, 2020
alterNERDtive added a commit that referenced this issue Jul 31, 2020
@alterNERDtive
RatAttack: not deprecating the pipe file for now
2dd74ec 
Passing parameters to VoiceAttack through the command line is not thread
safe. For RATSIGNALS coming in in rapid succession (either because,
well, several cases at once or when using an IRC bouncer, like I do) it
completely messes up the data.

see #51
@alterNERDtive alterNERDtive removed this from the future milestone Aug 17, 2020
@alterNERDtive alterNERDtive added the wontfix This will not be worked on label Aug 17, 2020
@alterNERDtive
Copy link
Owner Author

Obsolete, see #62. Invoking a helper tool and doing IPC instead.

@alterNERDtive alterNERDtive closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
@alterNERDtive alterNERDtive removed the wontfix This will not be worked on label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alterNERDtive alterNERDtive

Labels
enhancement New feature or request RatAttack
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alterNERDtive