Deploy action fails when news title contains apostrophe (')

[IBzerbasteln]

Have you checked that your issue isn't already filed?

• I read through FAQ and searched through the past issues, none of which addressed my issue.
• Yes, I have checked that this issue isn't already filed.

Bug description

I've added an inline announcement that contains an apostrophe which prevents the install and build action.

How to reproduce the bug

1. Add a news entry that contains an apostrophe. Mine is:

---
layout: post
date: 2024-10-18 10:38:00+0100
inline: true
related_posts: false
---

Invitation to speak at the Muséum National d'Histoire Naturelle (Paris).

2. Commit to main and push.
3. GitHub "Deploy site" action should be failing, specifically the "Install and Build" job.

Error messages and logs

Error: Process completed with exit code 1.

What operating system are you using?

Windows

Where are you seeing the problem on?

Running locally without Docker

More info

Things I've tried

Based on the information from this page, I've tried to replace the ' with different HTML encodings (' and ') and with escape syntax (\') but that didn't resolve the issue.

[george-gca]

I just tested and it worked fine. Are you using a recent version of the template?

A simple inline announcement with Markdown's emoji! :sparkles: :smile:

[IBzerbasteln]

That's odd---I've tried adding an apostrophe to the news entry that you modified as well, and that also keeps my page from being built. I've only forked the template repository on 6 November 2024 so I'd say I'm using a fairly recent version...

[george-gca]

Just checked your code and your _includes/news.liquid is almost identical as ours _includes/news.liquid.

Looking further into your error here, it is a uglifier error. Uglifier is run only when JEKYLL_ENV=production, which we set when the code is being deployed to GitHub sites.

So I tried to reproduce it locally with JEKYLL_ENV=production bundle exec jekyll serve and indeed it failed. Looking for a fix, since it actually failed while generating the search data.

[george-gca]

Check if this solves for you @IBzerbasteln.

[IBzerbasteln]

Works like a charm, thank you so much for solving this so quickly!