Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/yarn: new aport #714

Closed
wants to merge 3 commits into from
Closed

testing/yarn: new aport #714

wants to merge 3 commits into from

Conversation

errm
Copy link
Contributor

@errm errm commented Jan 10, 2017

https://yarnpkg.com/
Fast, reliable, and secure dependency management for Node.js.

@errm errm mentioned this pull request Jan 13, 2017
Closed
@errm errm force-pushed the yarn branch 5 times, most recently from 4eabf3a to abe99b1 Compare January 18, 2017 09:00
@tylerjharden
Copy link

Can this get merged in? What is the hold up?

fabled
fabled requested changes Jan 27, 2017
View reviewed changes
community/nodejs-current/APKBUILD
@@ -13,6 +13,7 @@ depends_dev="libuv"
makedepends="$depends_dev python2 openssl-dev zlib-dev libuv-dev linux-headers
paxmark binutils-gold http-parser-dev ca-certificates"
subpackages="$pkgname-dev $pkgname-doc"
provides="nodejs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to increment pkgrel for this change.

testing/yarn/APKBUILD
mv "$srcdir"/dist/lib "$pkgdir"/usr/share/yarn
mv "$srcdir"/dist/lib-legacy "$pkgdir"/usr/share/yarn
mv "$srcdir"/dist/node_modules "$pkgdir"/usr/share/yarn
mv "$srcdir"/dist/package.json "$pkgdir"/usr/share/yarn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally copy, or link things, so abuild can be ran multiple times for same source tree.

errm and others added 3 commits January 31, 2017 01:05
@errm @jirutka
testing/yarn: new aport
f60d874 
https://yarnpkg.com/
Fast, reliable, and secure dependency management for Node.js.
@jirutka
testing/yarn: fix various issues and try to minimize pkg size
9ee92ce
@errm @jirutka
community/nodejs-current: add provides=nodejs
8a7a505 
In order that yarn can be used with either version of nodejs.
@jirutka
Copy link
Member

jirutka commented Jan 31, 2017

It seems that this package is very desirable. I’ve fixed issues and gonna merge it.

@algitbot
Copy link

Merged in 529a068, febd214, 1c1cddd by @jirutka. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Jan 31, 2017
@samjarrett
Copy link

Given the official Docker node/alpine image (https://github.com/nodejs/docker-node/blob/28425ed95cebaea2ff589c1516d79c60181983b2/7.4/alpine/Dockerfile) uses alpine 3.4, is it possible to get this in the repo for 3.4 too?

@errm
Copy link
Contributor Author

errm commented Jan 31, 2017

@samjarrett packages in testing are only built for edge...

Package will be moved to main if there positive feedback or other good reasons.
see: https://wiki.alpinelinux.org/wiki/Aports_tree

Even if that happens it would end up landing in 3.6 I would imagine ...

@errm errm deleted the yarn branch January 31, 2017 12:13
@jpadilla
Copy link

Is it possible to install this package without installing a different version of node?

/app # node --version
v6.9.0
/app # echo http://nl.alpinelinux.org/alpine/edge/testing >> /etc/apk/repositories
/app # apk add --update-cache yarn
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.4/community/x86_64/APKINDEX.tar.gz
fetch http://nl.alpinelinux.org/alpine/edge/testing/x86_64/APKINDEX.tar.gz
(1/3) Installing libuv (1.9.1-r0)
(2/3) Installing nodejs (6.7.0-r0)
(3/3) Installing yarn (0.19.1-r0)
Executing busybox-1.24.2-r11.trigger
OK: 66 MiB in 21 packages
/app # node --version
v6.7.0

@jirutka
Copy link
Member

jirutka commented Jan 31, 2017

@jpadilla How have you installed your node?

@jpadilla
Copy link

@jirutka currently using https://github.com/mhart/alpine-node

@jirutka
Copy link
Member

jirutka commented Jan 31, 2017 •
edited
Loading

Aha… What about using clean alpine container and installing node using apk as any other package? We maintain package main/nodejs for LTS version of node, currently 6.9.2 in v3.5 (latest stable).

@jpadilla
Copy link

@jirutka will give that a try, thanks!

Daniel15
Daniel15 reviewed Jan 31, 2017
View reviewed changes
testing/yarn/APKBUILD
arch="noarch"
license="BSD-2"
depends="nodejs"
source="https://github.com/yarnpkg/$pkgname/releases/download/v$pkgver/$pkgname-v$pkgver.tar.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this to use https://yarnpkg.com/downloads/$pkgver/yarn-v$pkgver.tar.gz? In the Yarn project, we're trying to avoid hard-coding GitHub URLs for downloads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, changed in bfe221d.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirutka jirutka jirutka left review comments

@Daniel15 Daniel15 Daniel15 left review comments

@fabled fabled fabled requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@errm @tylerjharden @jirutka @algitbot @samjarrett @jpadilla @Daniel15 @fabled