content modelling/909 pension rate cadence #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously we had the enums as 'weekly', 'monthly' etc, but we now want to use this field as if it was the exact copy content designers would be pasting into documents. So we no longer call `humanize` on the enum because it should already be the humanized version. I think this is ok to do for now, as we do not have any other enums in CBM afaik, and if it causes problems we will need to revisit.
85b5641 to
a70f62c
Compare
pezholio
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/z9afIAop/909-update-cadence-label-and-values
This updates to reflect the new enum value for a rate's cadence #9960
Follow these steps if you are doing a Rails upgrade.