(908) Stop continue editing from removing existing embedded objects #9948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the draft in progress banner doesn’t look odd
Before, when editing a draft, the details that a user gave overrode the whole details object, meaning all embedded documents were removed. This assigns only the attributes we’re interested in, as well as merging the details hash from the form input, so anything that hasn’t come from the form remains intact. I’ve also had to update the `organisation_id=` method to set the organisation to nil if `organisation_id` is an empty string.
Harriethw
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/BsSW5pPS/908-bug-continue-editing-hides-existing-rates
Before, when editing a draft, the details that a user gave overrode the whole details object, meaning all embedded documents were removed.
This assigns only the attributes we’re interested in, as well as merging the details hash from the form input, so anything that hasn’t come from the form remains intact.
I’ve also had to update the
organisation_id=method to set the organisation to nil iforganisation_idis an empty string.