-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails-i18n from 7.0.5 to 7.0.6 #7042
Conversation
|
I think this is failing because of the new rules around Chinese, unnecessary use of |
Yeah I think you're right. I think there's two parts to this: the fixes to this code and potentially compatibility issues with rails_translation_manager. I imagine the code fixes aren't too hard. I think where we've got ZH whitehall/config/locales/zh.yml Lines 128 to 279 in e9c2107
and then fix places where it tries to look up a key it shouldn't in tests like: whitehall/test/unit/models/offsite_link_test.rb Lines 135 to 140 in e9c2107
where an The bit that seems more thorny to fix is rails_translation_manager, which is owned by #navigation-and-presentation-govuk (cc @chao-xian, is this something you've hit (yet)?, with this change in rails-i18n the are a lot of errors produced by that gem: Large console pasting of Rails Translation Manager errors
Where I think it should not expect a bunch of these 🤔 So I imagine bits like https://github.com/alphagov/rails_translation_manager/blob/b1b8a3b6ea355e0cebcc86b3b5da46efd4962422/config/locales/plurals.rb#L47-L50 will need a change |
@kevindew yes something similar in Frontend I think but not had a chance to look into it |
I've looked a bit more into this and I don't think it's actually as complex to fix as I made it sound in my first message. As I understand the issue isn't actually around the simplification commits (svenfuchs/rails-i18n#1033) and instead is related to the removal of pluralization rules in: svenfuchs/rails-i18n#1017 So I think we'll have to add plural rules for the languages that are no longer handled by rails-i18n. I calculate that to be 4 locales: "cy", "gd", "mt", "zh". Where I'm a bit confused about is what exactly needs to be updated, as we have both plurals in govuk_app_config and rails_translation_manager. I'm not sure if the latter is used as rails_translation_manager only seems to be installed as a dev dependency. |
I gave adding the rules to govuk_app_config a go and seem to be getting a successful build: https://ci.integration.publishing.service.gov.uk/job/whitehall/job/rails-I18n-7-kevin/ I've opened up a PR for govuk_app_config: alphagov/govuk_app_config#266 |
@dependabot rebase I think this might work ok since govuk_app_config 4.11.0 was released: https://github.com/alphagov/govuk_app_config/blob/main/CHANGELOG.md#4110 which Whitehall is using. |
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n) from 7.0.5 to 7.0.6. - [Release notes](https://github.com/svenfuchs/rails-i18n/releases) - [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md) - [Commits](svenfuchs/rails-i18n@v7.0.5...v7.0.6) --- updated-dependencies: - dependency-name: rails-i18n dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
89b9ce0
to
4f4b6bc
Compare
Bumps rails-i18n from 7.0.5 to 7.0.6.
Changelog
Sourced from rails-i18n's changelog.
Commits
a1daea1
Bump version 7.0.6b44b62a
Merge pull request #1055 from jolll4/master19baea9
removed x_yearsbc2ac26
Merge pull request #1056 from sunny/patch-282dc8f6
Include Dzongkha in CHANGELOGe2fa383
sv-FI to readme6cb81f2
updated changeloged458a3
removed fi remnants from dates507dd97
date formats37cc4b2
currency to eurosDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)