Fix slugs not propagating correctly in HTML pubs #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 28, 2013 13:11
Reworked the testing to include the changing of slugs whilst the publication is in draft, and then to fix the slug after that with successive publications.
|
This seems good, does it supercede #389 or od we just need to take care when merging that they don't clobber each other? |
|
#389 has already been merged, so we're good. The tests failed, but (again) was due to test server startup timeouts. |
h-lame
added a commit
that referenced
this pull request
Mar 28, 2013
Fix slugs not propagating correctly in HTML pubs https://www.pivotaltracker.com/story/show/46557791
|
Fail is JS test timeout (again). Code looks good though, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that HTML pub slugs were lagging one behind the edition,
and additionally that we want slugs to change in draft mode but not once
the HTML version is published. This PR fixes that by changing the logic
in
HtmlVersionto regenerate slugs only if the edition hasn't yet beenpublished.
Also includes a data migration to fix the titles and slugs for old HTML
pubs that were allowed to have blank titles.
More information on the ticket:
https://www.pivotaltracker.com/story/show/46557791