Require single colons for pseudo-element rules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is changed is prompted from a discussion in govuk_publishing_components [1] where the consensus was that we should maintain the single colon approach to pseudo-elements for IE8 compatibility. The logic for this was that, while we may not support IE8, syntax wasn't a sufficient reason to risk visual problems. Presumably this can be removed once we reach a point of deeming IE8 insignificant enough to no longer worry about or if auto-prefixer is ubiquitous (which can convert from double to single automatically in compilation in IE8). [1]: alphagov/govuk_publishing_components#1611 (comment)
This second release reflects the rule change that pseudo-elements must be defined with a single colon.
bc0970e to
0702461
Compare
kevindew
added a commit
to kevindew/govuk-frontend
that referenced
this pull request
Jul 20, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
kevindew
added a commit
to kevindew/govuk-frontend
that referenced
this pull request
Jul 21, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
vanitabarrett
pushed a commit
to alphagov/govuk-frontend
that referenced
this pull request
Aug 6, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
kevindew
added a commit
to kevindew/govuk-frontend
that referenced
this pull request
Aug 19, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
kevindew
added a commit
to kevindew/govuk-frontend
that referenced
this pull request
Sep 1, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
kevindew
added a commit
to kevindew/govuk-frontend
that referenced
this pull request
Sep 14, 2020
This enforces that psuedo elements are defined with a single colon. In the config/.sass-lint.yml file the rule for pseudo-elements was disabled which meant this project has a mix of both single colon and double colon pseudo elements. The rule to use single colon rather than double was requested by GOV.UK frontend developers as a means to not purposely break IE8 despite a lack of a official support, see alphagov/stylelint-config-gds#1 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is changed is prompted from a discussion in govuk_publishing_components where the consensus was that we should maintain the single colon approach to pseudo-elements for IE8 compatibility. The logic for this was that, while we may not support IE8, syntax wasn't a sufficient reason to risk visual problems.
Presumably this can be removed once we reach a point of deeming IE8 insignificant enough to no longer worry about or if auto-prefixer is ubiquitous (which can convert from double to single automatically in compilation in IE8).