New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Plurals #51

Closed

1pretz1 wants to merge 2 commits into main from update-plurals

Contributor

1pretz1 commented Nov 17, 2022

No description provided.

1pretz1 added 2 commits

November 17, 2022 13:04


          Wrap plural rules in a class

f1133ea

Wrapping the extra plural rules in a class will make it easier to
integrate them into other applications. Currently, only Rails
Translation Manager uses these rules whereas GOV.UK apps, e.g [Frontend]
uses rules defined in [govuk-app-config][2].

We'll be retiring the list in govuk-app-config for the following
reasons:

* maintaining two lists is confusing
* keeping all translation config in one place is simpler
* govuk-app-config is a dependency of many non-translated apps and so
  defining GovukI18n isn't needed for the majority of applications

[1]: https://github.com/alphagov/frontend/blob/765b2e150cd8aab43d4564197348ea2a40317410/config/locales/plurals.rb
[1]: https://github.com/alphagov/govuk_app_config/blob/9b0e5079410222c90d567cae314a0188cfdd85e6/lib/govuk_app_config/govuk_i18n.rb


          Update CHANGELOG

1pretz1 mentioned this pull request

Add plurals dropped from rails-i18n in 7.0.6 #49

Merged

Contributor Author

1pretz1 commented Nov 18, 2022

Closing as we don't need to wrap the plural list in a class as it's added to the load path of I18n already.

1pretz1 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet